Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: use const reference when decoding std::vector<jule::I32> #62

Merged
merged 1 commit into from
Jan 28, 2024
Merged

style: use const reference when decoding std::vector<jule::I32> #62

merged 1 commit into from
Jan 28, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Jan 28, 2024

Description

Altough utf16_decode for std::vector<jule::I32> is not yet defined, I think the input of that function should be passed by const reference.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing tests pass.
  • The code follows the code style and conventions of the project.
  • No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
  • I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Avoid passing std::vector<jule::I32> by value.

@mertcandav mertcandav self-requested a review January 28, 2024 09:32
@mertcandav mertcandav added bug Something isn't working compiler/runtime Related with runtime api About API labels Jan 28, 2024
mertcandav
mertcandav approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the parameter s should be passed by const reference.

Thanks for your contribution.

@mertcandav mertcandav merged commit 4f09340 into julelang:master Jan 28, 2024
4 checks passed
@vil02 vil02 deleted the pass_s_by_const_reference branch January 28, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcandav mertcandav mertcandav approved these changes

Assignees
No one assigned
Labels
api About API bug Something isn't working compiler/runtime Related with runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @mertcandav